georgemandis / konami-js

Adding the Konami Code easter egg to your projects since 2009! Compatible with gestures on smartphones and tablets as well. Compatible with all front-end frameworks and vanilla JavaScript
http://konamijs.mand.is/
MIT License
961 stars 121 forks source link

Modernize code with ES6-features and functional aesthetic #47

Closed georgemandis closed 6 years ago

georgemandis commented 6 years ago

The code could stand to make better use of ES6 features and modern JavaScript coding styles. This might be the most wide-open issue in terms of solving and I'm open to all manners and discussion on the subject.

Some low hanging fruit and ideas to get started:

If we can get a base rewrite that adheres to this we can break down the code and discuss more specific improvements.

DavideCarvalho commented 6 years ago
georgemandis commented 6 years ago

If you take a look at the 2.0 branch I've taken a pass at a complete rewrite. Will probably be easier to discuss specific changes from there.

Going to close this issue an an effort to consolidate things.