georgemilosh / Climate-Learning

How to predict extreme events in climate using rare event algorithms and modern tools of machine learning
https://georgemilosh.github.io/Climate-Learning/
MIT License
20 stars 5 forks source link

`nfolds` is kwarg of both `prepare_XY` and `k_fold_cross_val` which can cause problems #46

Closed georgemilosh closed 1 year ago

georgemilosh commented 1 year ago

Also 'u' is multiply defined in the config.json

AlessandroLovo commented 1 year ago

Yes, this is not a problem if you use ut.extract_nested and ut.set_values_recursive Also there is no easy fix because prepare_XY and k_fold_cross_val are independent functions that don't call each other, so we cannot simply forward the kwarg.

AlessandroLovo commented 1 year ago

I'll put it as a wontfix for now