fix burn_in for in_series output

georgeoshardo / SyMBac

Accurate segmentation of bacterial microscope images using deep learning synthetically generated image data.

https://doi.org/10.1186/s12915-022-01453-6

GNU General Public License v2.0

19 stars 9 forks source link

fix burn_in for in_series output #23

Closed erezli closed 2 years ago

lgtm-com[bot] commented 2 years ago

This pull request fixes 1 alert when merging 802e94882ebe47fb448a64569c706f2cb1e9a6ae into e3276592ffdc1ffe351d51ec4c9cebcf96a292e3 - view on LGTM.com

fixed alerts:

1 for Unused local variable

georgeoshardo commented 2 years ago

I see "parent": self.parent. Is this gonna slow things down? Or has that been fixed?

erezli commented 2 years ago

This "parent": self.parent is to ensure the second daughter and the first daughter share the same parent attribute. Assigning object to this self.parent attribute somehow slows things down so I fixed it by only assigning the id(object) to self.parent- several digits. I still couldn't figure out why assigning objects directly cause the problem, since it should only be a pointer to the object...