server/model dir should be emptied after each build (?)

georgepar / kaldi-grpc-server

Deploy Kaldi models using grpc for bidirectional streaming.

Apache License 2.0

17 stars 6 forks source link

server/model dir should be emptied after each build (?) #5

Open manosplitsis opened 2 years ago

manosplitsis commented 2 years ago

When building a new docker image, the model directory is copied to server/model, but the user has to remove the contents manually to build from a different model dir

georgepar commented 2 years ago

Yes that's by design. Imagine the case where actually the user doesn't have a backup of the model and the script goes on to delete it. Its better be annoying and make the user make the conscious decision to delete their model.

We could include a cmd line flag (-y) to bypass this, or make the script ask for permission interactively. Feel free to post a pr

georgepar commented 2 years ago

TODO: Add a flag to remove old models during model building