Closed kosniaz closed 2 years ago
Also, it could be useful to add a deadline to the connection. https://grpc.io/blog/deadlines/
I will try again with the env variable GRPC_VERBOSITY=DEBUG
TODO: Add verbose logs / error handling / connection deadline
Server doesn't close the connection when
kaldigrpc_client
disconnects before the end of stream. This has been noted both in the programmatic use, when we run theILSPASRClient.streaming_recognize
method, as well as when runningkaldigrpc-transcribe --streaming
from the cli.Expected Behavior
Streaming recognition works, and when we stop streaming audio and break the client print loop, the server worker disconnects from the grpc channel and is available again.
Current Behavior
Streaming recognition still works, but when we stop streaming audio and break the client print loop, the server worker doesn't disconnect from the grpc channel, and stays blocked for at least 30 minutes.
Possible Solution
Close the connection on the server side too. Possibly redefine the meaning of "end_of_stream"?
Steps to Reproduce
max_workers
, e.g. 5kaldigrpc-transcribe --streaming --port 1234 geopar.wav
and then Ctrl-C it after some secondsContext (Environment)
In the context of Virtual Assistants, where we need to perform an action when we recognize certain commands, we should be able to close the grpc channel abruptly.
Looking forwrard to further discussion and will be happy to assist in the implementation of a solution!