search

georgerobotics / cyw43-driver

Other
83 stars 42 forks source link

src/cyw43_ll.c: Fix some build warnings. #116

Closed peterharperuk closed 5 months ago

peterharperuk commented 5 months ago

Fixes #115

peterharperuk commented 5 months ago

@dpgeorge Any chance of getting this merged?

peterharperuk commented 5 months ago

Sorry to nag, but I can't update the cyw43-firmware in the pico-sdk with build warnings, so need these fixed.

dpgeorge commented 5 months ago

The CI for this repo does build the code with -Wpedantic enabled, but that didn't pick up the warnings. Is there any way to make the CI hit at least the unused variable warning?

peterharperuk commented 5 months ago

-Wextra seems to be the one that's causing this. Oddly pedantic fails for me. We use the following...

-Werror -Wall -Wextra -Wnull-dereference -Wuninitialized -Wunused -Wcast-align -Wall -Wcast-qual -Wfloat-equal -Wmissing-format-attribute -Wsign-compare -Wstrict-prototypes -Wno-inline -Wredundant-decls -Wno-shadow -Wno-missing-field-initializers -Wno-missing-braces -Wno-multichar

dpgeorge commented 5 months ago

Thanks for updating, now merged.

dpgeorge commented 5 months ago

-Wextra seems to be the one that's causing this

Thanks for that. I've now enabled this in the CI tests on this repo, see #117.