search

georgerobotics / cyw43-driver

Other
83 stars 42 forks source link

fixing compiler warnings #88

Closed beechwoods-software closed 1 year ago

beechwoods-software commented 1 year ago

The lack of casts in these debug messages was resulting in compiler warnings in my enviornment.

dpgeorge commented 1 year ago

Thanks for the contribution.

Instead of this approach, I'd rather change the format codes to all use %u and %d and %x, ie just use the non-long versions. That's more suitable to embedded development (smaller strings, no need for the embedded printf to support long args).

Feel free to update this PR to do this, or otherwise I can do it.

beechwoods-software commented 1 year ago

Thanks for the contribution.

Instead of this approach, I'd rather change the format codes to all use %u and %d and %x, ie just use the non-long versions. That's more suitable to embedded development (smaller strings, no need for the embedded printf to support long args).

Feel free to update this PR to do this, or otherwise I can do it.

I guess I just did it on a different PR. Probably easiest to just close this one and use the other?