georgeslabreche / opssat-onboard-image-denoiser

Generative AI and Autoencoders to Denoise Images Onboard the European Space Agency's OPS-SAT-1 Spacecraft!
https://tanagraspace.com
MIT License
1 stars 0 forks source link

consolidate calculate_metrics #74

Closed georgeslabreche closed 4 months ago

georgeslabreche commented 11 months ago

It should always be executed from here: https://github.com/georgeslabreche/opssat-onboard-image-denoiser/blob/main/results/calculate_metrics.py

Implement this FIXME: https://github.com/georgeslabreche/opssat-onboard-image-denoiser/blob/b68c918e797137d8342bd2956243b12c8fe68245/results/calculate_metrics.py#L137-L141

And this one as well: https://github.com/georgeslabreche/opssat-onboard-image-denoiser/blob/b68c918e797137d8342bd2956243b12c8fe68245/results/calculate_metrics.py#L173-L177

Delete all other calculate_metrics, that is:

cguz commented 10 months ago

Jo Jo @georgeslabreche

I did a first version. Now, it is executed from:

https://github.com/georgeslabreche/opssat-onboard-image-denoiser/blob/74-consolidate-calculate_metrics/results/calculate_metrics.py

However, to unify the two functions is not straightforward:

https://github.com/georgeslabreche/opssat-onboard-image-denoiser/blob/0aa41a7f1705ce0af3cbfd6545ae1618efd0a0b9/results/calculate_metrics.py#L40-L45

https://github.com/georgeslabreche/opssat-onboard-image-denoiser/blob/0aa41a7f1705ce0af3cbfd6545ae1618efd0a0b9/results/calculate_metrics.py#L78-L85

First, it requires to:

Please, take a look