Open georgesnow opened 5 years ago
MacPassRevealer looks like something that is worth moving into core MacPass without the need for a plugin. There is a related issue on MacPass asking for "MenuItem" only display without having the app inside the dock so this might be work combining
What you describe here is sort of a project, so you might want to use Github's feature instead of putting everything inside an issue.
I had a feeling that it was turning into something "more". I did see that thread. It partially inspired the idea to build the plugin. I look into moving this to a project.
I am very new at ObjC. When I though about trying to build the functionality and how to incorporate into the core code it seemed awfully daunting. The plugin worked well because it containerized what i was doing for testing, limiting the impact (breaking other stuff), and troubleshooting. Also it's been helping me with learning ObjC better :)
If you are ok with it. I would like to refine it a bit further as a plugin. Maybe set a milestone or two? ie reaches certain set of functionality it would be time to move it into the core code.
I have done some more testing with the other functionality listed above. You can see it in my latest commit.
fixed almost all of these. the search from status item is still interesting to me. However, the latest update with landing search context and landing the focus in the search field make some parts of it less needed. Maybe down the road. I discovered I can show the different view controllers in the pop over. Password Generator, list view, and others. Downside is they are new instances not currently opened ones.
@mstarke update on the hiding of Dock icon. I have tried a number of ways of hiding the dock icon from the plug-in. And after hiding the dock icon. I get a lot of strange behavior when you open more then one window. example would be you have 1 open database and then you open the preferences window. In one case I lost the ability to hide MacPass, in another I couldn't select the preferences window, and different time it broke the hotkey. However, as soon as change it back to show the dock icon all the behavior returns to normal.
I am not sure if thats the plugin or if it's because dock icon is now hidden that it breaks the first responder chain or delegates. And since I couldn't get consistent bad behavior it made hard to troubleshoot.
I glossed over the code. I think the best solution might be to spec the behaviour and re-implement it in MacPass with minor (and mayor) changes in the implementation.
If you want to make a branch and frame out where you want stuff. I can build the basic functionality and features? That way you can curate it to better fit with the core code. Cause I think you are right my code grew in a way that isn’t easy to just import wholesale. Does that work for you?
Roadmap for plugin Ordering is sort of arbitrary and may change depending on difficulty and time Also not sure what is more important to other users
Follow-up need to follow up with @mstarke about these
Fixes
Enhancements Short-term
Short-mid term (not sure of possibility)
Long-term would be really cool not sure if it will happen