georgetown-cset / funder-finder

Retrieve GitHub repo funding information
Apache License 2.0
7 stars 2 forks source link

Handle nonexistent repos in gh sponsors, match tidelift in more cases and update return value #44

Closed jmelot closed 1 year ago

github-actions[bot] commented 1 year ago

No need for rebasing :+1: behind_count is 0 ahead_count is 2

jmelot commented 1 year ago

So the tidelift tests now fail for georgetown-cset/funder-finder because we now have tidelift in our README. :) How do you want to handle this? If we think many funded repos will just mention tidelift in their readme without a link we should keep the current behavior and change the test to another unfunded repo. Or if we think that most funded repos will include a link to tidelift, we could update the string to tidelift.com. Or we could switch over completely to this https://github.com/georgetown-cset/funder-finder/issues/35, although we might lose some repos that way

jspeed-meyers commented 1 year ago

On the tests failing: Let's keep the current behavior and change the test case. Perhaps another CSET repo?

github-actions[bot] commented 1 year ago

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
594 425 72% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
funderfinder/sources/github_sponsors.py 55% 🟢
funderfinder/sources/tidelift.py 74% 🟢
tests/sources/test_tidelift.py 100% 🟢
TOTAL 76% 🟢

updated for commit: 9db162e by action🐍

jspeed-meyers commented 1 year ago

Nice! Ship it!