Closed jmelot closed 1 year ago
So the tidelift tests now fail for georgetown-cset/funder-finder
because we now have tidelift in our README. :) How do you want to handle this? If we think many funded repos will just mention tidelift in their readme without a link we should keep the current behavior and change the test to another unfunded repo. Or if we think that most funded repos will include a link to tidelift, we could update the string to tidelift.com. Or we could switch over completely to this https://github.com/georgetown-cset/funder-finder/issues/35, although we might lose some repos that way
On the tests failing: Let's keep the current behavior and change the test case. Perhaps another CSET repo?
current status: ✅
Overall Coverage
Lines Covered Coverage Threshold Status 594 425 72% 0% 🟢 New Files
No new covered files...
Modified Files
File Coverage Status funderfinder/sources/github_sponsors.py 55% 🟢 funderfinder/sources/tidelift.py 74% 🟢 tests/sources/test_tidelift.py 100% 🟢 TOTAL 76% 🟢 updated for commit:
9db162e
by action🐍
Nice! Ship it!
No need for rebasing :+1: behind_count is 0 ahead_count is 2