search

georgetown-cset / funder-finder

Retrieve GitHub repo funding information
Apache License 2.0
7 stars 3 forks source link

Change import path for get_funding_sources function #60

Closed jspeed-meyers closed 1 year ago

jspeed-meyers commented 1 year ago

What is the correct import path for get_funding_sources? On my machine, I had to make this small change.

This is probably a "me" problem. wdyt?

github-actions[bot] commented 1 year ago

No need for rebasing :+1: behind_count is 0 ahead_count is 2

jspeed-meyers commented 1 year ago

But clearly this introduces a bug into CI. What am I missing?

jmelot commented 1 year ago

Ugh yeah there seems to be some complexity with the project organization/imports I/we need to sort out. In the meantime, does this https://github.com/georgetown-cset/funder-finder/pull/60/commits/482f0587fc572a0b801b7d24dbc243c96b411656 work for you?

github-actions[bot] commented 1 year ago

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
615 443 72% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 482f058 by action🐍

jspeed-meyers commented 1 year ago

Sounds good to me :) Should this PR be merged or closed?

Thank you!

jmelot commented 1 year ago

I guess I'll merge it for the sake of updating the readme. Sorry for the confusion/undocumented change in the way this gets run!