georgetown-cset / parat

🦜 PARAT: CSET's Private-sector AI-Related Activity Tracker
https://parat.cset.tech
Other
5 stars 0 forks source link

Display 'n/a' for jobs when no LinkedIn page available #321

Closed brianlove closed 5 months ago

brianlove commented 5 months ago

If a company has no LinkedIn page, display 'n/a' for the jobs counts instead of zero to not give an incorrect impression of the jobs counts.

Closes #234

image

Questions

@za158 How should the 'Workforce' section of the detail page be handled for these cases?

image

github-actions[bot] commented 5 months ago

No need for rebasing :+1: behind_count is 0 ahead_count is 2

github-actions[bot] commented 5 months ago

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
572 370 65% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 2bed65f by action🐍

github-actions[bot] commented 5 months ago

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 67%
67.91% (398/586) 57.78% (193/334) 68.04% (132/194)
Modified Files • (67%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files67.9157.7868.0467.57 
components64.2259.0762.5963.76 
   DetailViewWorkforce.jsx000011–25
static_data70.5848.487567.74 
   table_columns.js69.6948.487566.66196–229, 246–248, 276, 322–348, 365–596
za158 commented 5 months ago

@brianlove Is it ~easy to hide the content in its entirety (big numbers plus explanatory text) and just put in some explanatory text TK?

(I'm implicitly assuming that if we lack data for one, we lack data for both - is that always the case?)

brianlove commented 5 months ago

Yes, displaying some other text instead of these stat boxes is quite easy.

Your assumption checks out - my investigations revealed that if the linkedin array is empty (the check that I'm using for displaying "n/a" here), both ai_jobs and tt1_jobs are always zero. There are also cases where a non-empty linkedin array has zeros for one or more job stats, but those are still displayed.

brianlove commented 5 months ago

Text contents and alert styles TBD: image