Closed brianlove closed 5 months ago
No need for rebasing :+1: behind_count is 0 ahead_count is 2
current status: ✅
Overall Coverage
Lines Covered Coverage Threshold Status 572 370 65% 0% 🟢 New Files
No new covered files...
Modified Files
No covered modified files...
updated for commit:
2bed65f
by action🐍
Lines | Statements | Branches | Functions |
---|---|---|---|
67.91% (398/586) | 57.78% (193/334) | 68.04% (132/194) |
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s |
---|---|---|---|---|---|
All files | 67.91 | 57.78 | 68.04 | 67.57 | |
components | 64.22 | 59.07 | 62.59 | 63.76 | |
DetailViewWorkforce.jsx | 0 | 0 | 0 | 0 | 11–25 |
static_data | 70.58 | 48.48 | 75 | 67.74 | |
table_columns.js | 69.69 | 48.48 | 75 | 66.66 | 196–229, 246–248, 276, 322–348, 365–596 |
@brianlove Is it ~easy to hide the content in its entirety (big numbers plus explanatory text) and just put in some explanatory text TK?
(I'm implicitly assuming that if we lack data for one, we lack data for both - is that always the case?)
Yes, displaying some other text instead of these stat boxes is quite easy.
Your assumption checks out - my investigations revealed that if the linkedin
array is empty (the check that I'm using for displaying "n/a" here), both ai_jobs
and tt1_jobs
are always zero. There are also cases where a non-empty linkedin
array has zeros for one or more job stats, but those are still displayed.
Text contents and alert styles TBD:
If a company has no LinkedIn page, display 'n/a' for the jobs counts instead of zero to not give an incorrect impression of the jobs counts.
Closes #234
Questions
@za158 How should the 'Workforce' section of the detail page be handled for these cases?