Closed brianlove closed 1 month ago
No need for rebasing :+1: behind_count is 0 ahead_count is 1
current status: ✅
Overall Coverage
Lines Covered Coverage Threshold Status 594 423 71% 0% 🟢 New Files
No new covered files...
Modified Files
No covered modified files...
updated for commit:
78c516e
by action🐍
Lines | Statements | Branches | Functions |
---|---|---|---|
67.45% (398/590) | 54.18% (207/382) | 68.1% (126/185) |
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s |
---|---|---|---|---|---|
All files | 67.45 | 54.18 | 68.1 | 67.2 | |
components | 64.17 | 54.36 | 62.59 | 63.72 | |
DetailViewPatents.jsx | 0 | 0 | 0 | 0 | 15–216 |
I don't think the Microsoft in [Robotics, Document Management & Publishing, Military] cases you mentioned are consistent with #357. In that issue, the problem is that there are no underlying data (counts
is an empty array), so the x-axis shows the interval [-1, 6] (likely a Plotly default). In these cases, however, the data are present (via the group's counts
value in overall_data.json
), they are just extremely low (mostly zeros for the y-axis, with one year reaching 1). The x-axis, however, for these cases still have the correct years displayed (2013-2023).
We may want to handle low-data categories like these differently, but I think that's an analytic question to resolve, not a technical issue with the current state of the app.
Ah ok got it, I misread that issue. I'll ping Zach about what to do about subfields without patent data
Organize the various options in the dropdown menu controlling the patent trends chart to group related options together and remove other (non-charted) options.
Closes #337, closes #357