georgetown-cset / parat

🦜 PARAT: CSET's Private-sector AI-Related Activity Tracker
https://parat.cset.tech
Other
4 stars 0 forks source link

Rework window sizes to resolve squished pages #448

Closed brianlove closed 1 week ago

brianlove commented 1 week ago

Rework window size detection to prevent desktop pages from loading in a "squished" state before adjusting, at the expense of mobile pages briefly showing the table of contents before it is hidden. Closes #240.

Fix several cases of keys not being present in loops. Updated browserslist DB.

@za158 @jmelot Video showing the TOC-on-mobile situation that results from this PR:

https://github.com/georgetown-cset/parat/assets/22353962/83887329-ab6d-4d5f-b472-11f084d6482f

github-actions[bot] commented 1 week ago

No need for rebasing :+1: behind_count is 0 ahead_count is 1

github-actions[bot] commented 1 week ago

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
597 426 71% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 1eaba90 by action🐍

github-actions[bot] commented 1 week ago

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 67%
68.07% (420/617) 55.88% (223/399) 69.94% (135/193)
Modified Files • (67%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files68.0755.8869.9467.86 
components63.5154.8564.4463.06 
   AddRemoveColumnDialog.jsx93.3387.587.593.1122, 142
util83.1552.6384.8486.04 
   useWindowSize.js93.755010093.3316
za158 commented 1 week ago

seems alright, few (<20%) of our users are on mobile

Zachary Arnold Analytic Lead, Emerging Technology Observatory (web http://eto.tech | LinkedIn https://www.linkedin.com/company/emerging-technology-observatory | Substack http://etoblog.substack.com) Center for Security and Emerging Technology @.***

On Fri, Jun 21, 2024 at 10:10 AM github-actions[bot] < @.***> wrote:

JavaScript Coverage Summary Lines Statements Branches Functions [image: Coverage: 67%] https://github.com/georgetown-cset/parat/blob/1eaba9004e4fc0f04aeedd2e5b7eee547e9b9970/README.md 68.07% (420/617) 55.88% (223/399) 69.94% (135/193) Modified Files • (67% ) File% Stmts% Branch% Funcs% LinesUncovered Line #s All files 68.07 55.88 69.94 67.86 components 63.51 54.85 64.44 63.06 AddRemoveColumnDialog.jsx https://github.com/georgetown-cset/parat/blob/1eaba9004e4fc0f04aeedd2e5b7eee547e9b9970/web/gui-v2/src/components/AddRemoveColumnDialog.jsx 93.33 87.5 87.5 93.1 122 https://github.com/georgetown-cset/parat/blob/1eaba9004e4fc0f04aeedd2e5b7eee547e9b9970/web/gui-v2/src/components/AddRemoveColumnDialog.jsx#L122, 142 https://github.com/georgetown-cset/parat/blob/1eaba9004e4fc0f04aeedd2e5b7eee547e9b9970/web/gui-v2/src/components/AddRemoveColumnDialog.jsx#L142 util 83.15 52.63 84.84 86.04 useWindowSize.js https://github.com/georgetown-cset/parat/blob/1eaba9004e4fc0f04aeedd2e5b7eee547e9b9970/web/gui-v2/src/util/useWindowSize.js 93.75 50 100 93.33 16 https://github.com/georgetown-cset/parat/blob/1eaba9004e4fc0f04aeedd2e5b7eee547e9b9970/web/gui-v2/src/util/useWindowSize.js#L16

— Reply to this email directly, view it on GitHub https://github.com/georgetown-cset/parat/pull/448#issuecomment-2182830877, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOAZR66665E3QNM4Q42R523ZIQX4BAVCNFSM6AAAAABJWAGTZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBSHAZTAOBXG4 . You are receiving this because you were mentioned.Message ID: @.***>