Add download step - Githubissues

georgewfraser / java-language-server

Java language server using the Java compiler API

MIT License

642 stars 126 forks source link

Open albfan opened 1 year ago

albfan commented 1 year ago

fixes #242

albfan commented 1 year ago

Added another fix to use downloaded jdk for jlink

georgewfraser commented 1 year ago

Can you please separate this into two PRs @albfan ? These changes are pretty unrelated and I'm not sure the JAVA_HOME bit will work in all cases.

albfan commented 1 year ago

We can do a better fallback for jlink.

About Split, what is it? split by OS?

georgewfraser commented 1 year ago

The two commits. I'm not sure if adding the JAVA_HOME/... bit will work with the CI scripts.

albfan commented 1 year ago

hmm, yes, that change don't make much sense and is unrelated with fix. Not sure why I needed, jlink is resolvable in my PATH