search

georgewfraser / vscode-tree-sitter

Accurate syntax coloring for VSCode using tree-sitter
MIT License
175 stars 25 forks source link

Merge theme with "editor.tokenColorCustomizations" #25

Closed seivan closed 4 years ago

seivan commented 4 years ago

Technically it only merges with "editor.tokenColorCustomizations.textMateRules" but that's a good start. It only merges if the override has a value set so we don't remove anything.

Edit: Would be nice to have scopes.ts as its own package.

georgewfraser commented 4 years ago

I appreciate the contribution! Could you please change the style back to regular for loops / if statements? I know some people think streaming-style pipelines are better, but I am not one of them.

seivan commented 4 years ago

Sorry, I’m just pushing these upstream from the RA changes added. But isn’t just a syntax change I’m also using VSCode to load and parse the package and filter out unusable extensions.

Edit: To avoid maintaining two different versions of these changes, I'll just wait until it's merged upstream and I'll edit the final copy to fit your style better.