Open Geobert opened 5 years ago
It would be great if you would tackle this---there's a guide in the README.md for how to contribute, and I've tried to outline a "colorization philosophy" here.
The colors seems hardcoded, can you try to retrieve the colors from the current theme?
At the moment it is not possible to use TextMate scope colors programatically: https://github.com/microsoft/vscode/issues/32813#issuecomment-488572556
If VSCode adds a way to use TextMate scope colors in setDecorations
, then we will switch to that and eliminate the treeSitter.field/function/type
colors from package.json
. In the meantime, the only solution is for the color themes to add treeSitter.field/function/type
.
BTW the tree-sitter playground is very helpful for understanding the syntax tree that we are using for colorization: https://tree-sitter.github.io/tree-sitter/playground
It would be great if you would tackle this
No promise, I'm missing time on my own projects already (life, life…) and don't know a thing about JS nor Typescript (JVM and native programmer here)
First, thanks for figuring out the Windows/Linux issue! Many little things to adjust:
ServerError
is a type and not highlightedServerError::new
,new
is a function and not highlightedErr
andOk
are enum variant ofstd::result::Result
, I don't know if they're supposed to be hightlighted, just pointing a difference hereget_user_id
,user_sessions_key
andtransaction
are functions and not hightlightedAnd a question: The colors seems hardcoded, can you try to retrieve the colors from the current theme? (I know we can customize them in the meantime :) )
No tree-sitter![image](https://user-images.githubusercontent.com/72570/58084341-92468100-7bb2-11e9-8067-38f160a1e7c5.png)
Tree-sitter![image](https://user-images.githubusercontent.com/72570/58084363-9d99ac80-7bb2-11e9-86b3-dee72e685a12.png)