NP_GetPluginVersion has incorrect const-ness

georgeyeo / npapi-sdk

Automatically exported from code.google.com/p/npapi-sdk

0 stars 0 forks source link

NP_GetPluginVersion has incorrect const-ness #13

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

Fairly minor thing; I can't find any plugin out there that exports this, short 
of demo ones. But may as well correct it to match NP_GetMIMEDescription's fix. 
Mozilla's already casting the function to the const version anyway.

http://mxr.mozilla.org/mozilla-central/source/dom/plugins/base/nsPluginsDirUnix.
cpp#359

Patch attached.

Original issue reported on code.google.com by davidben@davidben.net on 9 Oct 2011 at 5:31

Attachments:

0001-Fix-const-ness-of-NP_GetPluginVersion.patch

GoogleCodeExporter commented 9 years ago

I support. Pointers to const should be used everywhere, where data is not 
intended to be modified. An exception might be a pointer to const pointer to 
const data, which is not supported in C.

Original comment by Van...@gmail.com on 23 Feb 2012 at 9:40