search

georgezhao2010 / midea_ac_lan

Auto-configure and then control your Midea M-Smart devices (Air conditioner, Fan, Water heater, Washer, etc) via local area network.
MIT License
1.24k stars 195 forks source link

Fixed incorrect filename in config #465

Open rryk opened 4 months ago

rryk commented 4 months ago

Fixes issue #464

skysyk commented 3 months ago

@georgezhao2010 please review, thank you!

wuwentao commented 1 month ago

@rryk @wuchu @skysyk

as current repo is not active more than 6 months. I have forked it and consider to maintain it in futuer. https://github.com/wuwentao/midea_ac_lan

PR is welcome

Thanks

rryk commented 1 month ago

I don't see hacs.json in your forked repo, so not sure if my pull request is applicable. On the other hand, I see my fix in diff on https://github.com/georgezhao2010/midea_ac_lan/compare/master...wuwentao:midea_ac_lan:master. Not sure why the file is gone though. Maybe it was removed in some later commit and that doesn't show in that view.

Either way, thanks for picking this up. I've installed the integration manually by checking out my own fork on the device, but I don't have the time to maintain it (accept pull requests and such), so glad that you do :-).

wuwentao commented 1 month ago

I don't see hacs.json in your forked repo, so not sure if my pull request is applicable. On the other hand, I see my fix in diff on master...wuwentao:midea_ac_lan:master. Not sure why the file is gone though. Maybe it was removed in some later commit and that doesn't show in that view.

Either way, thanks for picking this up. I've installed the integration manually by checking out my own fork on the device, but I don't have the time to maintain it (accept pull requests and such), so glad that you do :-).

Why you don't see hacs.json in diff: as most of the PR in current repo try to fix this input error, and we have fixed it in https://github.com/wuwentao/midea_ac_lan so you can directly access it and check the file, it should be exist and already have right value now in additional, there is too many code changes by python-black and python-isort code format tool, also fixed python flake8 with old source code, you can check the detail in my repo about the changes. now it should be more script checks rule in new fork.

you can continue use your fork if you don't need any new update.