Arithmetic expression support in Parser

georgia-tech-db / evadb

Database system for AI-powered apps

https://evadb.ai/docs

Apache License 2.0

2.59k stars 261 forks source link

Arithmetic expression support in Parser #1093

Open xzdandy opened 8 months ago

xzdandy commented 8 months ago

Search before asking

[X] I have searched the EvaDB issues and found no similar feature requests.

Description

Currently, EvaDB does not have arithmetic expression support in https://github.com/georgia-tech-db/evadb/blob/staging/evadb/parser/lark_visitor/_expressions.py. So expression in projection or predicate with arithmetic operations does not work. Simple query to test:

SELECT 1+2;

Use case

No response

Are you willing to submit a PR?

[ ] Yes I'd like to help by submitting a PR!

aayushacharya commented 3 months ago

Hi, may I work on this feature?

aayushacharya commented 3 months ago

I have added PR #1444 corresponding to this feature. I would love to get feedback if changes need to be made. The supported operations in precedence are:

Multiplication *, Division / and Modulo %
Addition + and Subtraction -