search

georgia-tech-db / evadb

Database system for AI-powered apps
https://evadb.ai/docs
Apache License 2.0
2.64k stars 262 forks source link

Adding pre-commit and some formatting #1449

Open lnxpy opened 8 months ago

lnxpy commented 8 months ago

This PR contains:

We can specify which docstring convention should be checked while committing.

:warning: Based on the changes that I've made, source/dev-guide/contribute.html doc needs to be updated. I can work on them as well.

This PR closes #1347

lnxpy commented 8 months ago

👋 Hello @lnxpy, thanks for submitting a EVA DB PR 🙏 To allow your work to be integrated as seamlessly as possible, we advise you to:

  • ✅ Verify that your PR is up-to-date with georgia-tech-db/eva master branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • ✅ Verify that all EVA DB Continuous Integration (CI) checks are passing.
  • ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition.

I think this CI message needs an update too. The default branch is staging not master.

gaurav274 commented 8 months ago

@lnxpy Thanks for the effort, let me fix the build and then merge your PR.

lnxpy commented 8 months ago

Hi @gaurav274! That's fine! Take your time. Before you merge this, please note that some changes should be made in the docs too.

I'm working on #1348 as well so the contribution guideline will need a major update after that.