georgian-io-archive / foreshadow

An automatic machine learning system
https://foreshadow.readthedocs.io
Apache License 2.0
29 stars 2 forks source link

Fix get_params for every internal class #129

Closed cchoquette closed 5 years ago

cchoquette commented 5 years ago

Description

The get_params for each estimator (anything that extends from BaseEstimator) will need to be overridden to ensure that all the correct parameters are displayed. This issue arises as the sklearn get_params implementation inspects the init of the current class naively. This inspection leads to two problems:

  1. anything not in the __init__ will not be displayed
  2. anything passed to a parent via **kwargs will not be shown. We must handle these cases separately.

Correct parameters to display.

Unit tests may take up most of the time.

Estimate: 2 days