georgian-io-archive / foreshadow

An automatic machine learning system
https://foreshadow.readthedocs.io
Apache License 2.0
29 stars 2 forks source link

Foreshadow object serialization and deserialization plus a simple python script wrapper #154

Closed jzhang-gp closed 5 years ago

jzhang-gp commented 5 years ago

Description

jzhang-gp commented 5 years ago

The new changes has removed the CustomizedParamsMixin completely since we can just use deep=False in get_params and dict_serialize. In fact, we should probably default deep=False. I don't see a use case where we are using deep=True? The whole CustomizeParamsMixin and many other customization around (de)serialization were based on the impression that we use deep=True, which generates a lot of verbose data we don't need to show. For now I hardcoded a few places to use deep=False when overriding parent's dict_serialize. If this makes sense, I'll change the function signature to use False as the default value.