georgian-io / Multimodal-Toolkit

Multimodal model for text and tabular data with HuggingFace transformers as building block for text data
https://multimodal-toolkit.readthedocs.io
Apache License 2.0
587 stars 84 forks source link

There is a small mistake in tabular_combiner.py #9

Closed weibobo2015 closed 1 year ago

weibobo2015 commented 2 years ago

As the title says, there is a mistake in tabular_combiner.py. Line 409: g_num = (torch.cat([w_text, w_cat], dim=-1) * self.weight_a).sum(dim=1).unsqueeze(0).T

should change to: g_num = (torch.cat([w_text, w_num], dim=-1) * self.weight_a).sum(dim=1).unsqueeze(0).T

because it is in a numerical part which should use w_num instead of w_cat