search

georgicodes / etsy-js

etsy-js is an asynchronous nodeJS wrapper for the etsy v2 api.
https://www.npmjs.org/package/etsy-js
35 stars 25 forks source link

Adding scopes #1

Open Datise opened 9 years ago

Datise commented 9 years ago

Hi, I'm a student at a bootcamp in vancouver, I've been trying to figure out how to add permission scopes to the client.requestToken when my api authenticates but can't seem to get it working. I see its on your Next Steps but I was wondering if you had any suggestions for now? I was hoping to at least add get listing_w.

edit: Nvm I fixed it, went into your lib and added them manually. Thanks for the contribution btw.. Etsy Api has been very difficult.

georgicodes commented 9 years ago

@Datise. awesome! Yeah it would be nice to pass in the scope instead of having it hardcoded that's for sure.

httpNick commented 9 years ago

Haha I just saw this after I sent in a merge request to add in an addScope method.. too funny. : D

Datise commented 9 years ago

I ended up writing probably a worse version of the same method but never thought to do a pull request. Nice to someone did it!