search

georgkrause / language_data

An optional supplement to `langcodes` that stores names and statistics of languages.
MIT License
5 stars 1 forks source link

Replace deprecated pkg_resources.resource_filename with importlib_res… #5

Closed georgkrause closed 6 days ago

georgkrause commented 9 months ago

…ources.files

github-actions[bot] commented 9 months ago

Test Results

5 files  5 suites   1m 31s :stopwatch: 1 tests 1 :white_check_mark: 0 :zzz: 0 :x: 5 runs  5 :white_check_mark: 0 :zzz: 0 :x:

Results for commit ccf5a89f.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 9 months ago
Package Line Rate Complexity Health
. 18% 0 ❌
. 18% 0 ❌
. 19% 0 ❌
. 18% 0 ❌
. 18% 0 ❌
Summary 19% (282 / 1520) 0 ❌
georgkrause commented 9 months ago

Considering this will break compatibility with python 3.8 this has to wait until October this year.

ddorian commented 7 months ago

Considering this will break compatibility with python 3.8 this has to wait until October this year.

Maybe support both ways like many projects do?

georgkrause commented 7 months ago

Maybe support both ways like many projects do?

I am not sure what exactly you mean. Both python versions or both code versions?

From my perspective all current python versions are supported with the current implementation. Supporting both versions of the code introduces a complexity and I don't see any reason to do that when we can just wait for a few months.