search

georgmartius / vid.stab

Video stabilization library
http://public.hronopik.de/vid.stab/
Other
838 stars 110 forks source link

check availability of SSE* instructions on target platform #114

Closed Karry closed 2 years ago

Karry commented 2 years ago

Checking sse instructions on build host by reading /proc/cpuinfo is not usable for crosscompilation.

Fix for https://github.com/georgmartius/vid.stab/issues/109

georgmartius commented 2 years ago

Hi Karry, thanks for fixing this. On which platforms have you tried it so far?

Karry commented 2 years ago

I tried it on armv7l (directly on hardware) and aarch64 crosscompilation. And of course on x86_64.

georgmartius commented 2 years ago

Wonderful.

georgmartius commented 2 years ago

I was running the checks and they failed. Can you also see them? If I understand correctly, the cmakefile in the test folder also need adaptation, right?

Karry commented 2 years ago

It is good to have CI builds ;-) It is just necessary to replace PROJECT_SOURCE_DIR by CMAKE_CURRENT_LIST_DIR