georgmartius / vid.stab

Video stabilization library
http://public.hronopik.de/vid.stab/
Other
843 stars 108 forks source link

Soname must be upgraded to 1.0.0 #15

Closed marillat closed 10 years ago

marillat commented 10 years ago

Hi, As the ABI has been changed in 0.98 the library soname change from 0.9.6 to 0.9.8 isn't enough and MAJOR_VERSION must be upgraded to 1

georgmartius commented 10 years ago

I see, yes this was a mistake. Can you tell me the rules again: if the ABI changes do I need to change the first number or is the second enough? I have a larger change in the pipeline for the 1.0 but then maybe we put it 1.1 or 2.0.

marillat commented 10 years ago

The first number change is mandatory when for the ABI change. You can changes others numbers when you do micro change to the ABI. See the libtool documentation. http://www.gnu.org/software/libtool/manual/libtool.html#Versioning

TimothyGu commented 10 years ago

Please merge #18 ASAP. ABI issues should always be regarded as first priority.