Closed TimothyGu closed 10 years ago
But shouldn't this option be ON by default. Now it would be OFF right?
Yes. Would you like the behavior to be the new default? If so, I can omit the removal of option() in the patch.
Yes, I think the shared objects should be build by default. But you write that something disrupts toolchain files. What do you mean by that?
In mxe we manage the libtype through using a cmake toolchain file which sets or clears BUILD_LIBS_SHARED. However the cmake toolchain file is applied before the option default is set, which means the so-called "initial" or "default" value overrides the user-applied setting.
Mh, I see. this seams a general problem, how is it solved by other projects. I want options and they should have default values. I think that for normal usages the shared libs should be by default on. Do you see a way of achieving this?
-1 it was fine before
I decided to drop the patch.
So what do I have to do, in order to compile vidstab for static linking into ffmpeg?
The option() disrupts toolchain files.