search

georgmartius / vid.stab

Video stabilization library
http://public.hronopik.de/vid.stab/
Other
857 stars 109 forks source link

Fix if BUILD_SHARED_LIBS is OFF #20

Closed TimothyGu closed 10 years ago

TimothyGu commented 10 years ago

The option() disrupts toolchain files.

georgmartius commented 10 years ago

But shouldn't this option be ON by default. Now it would be OFF right?

TimothyGu commented 10 years ago

Yes. Would you like the behavior to be the new default? If so, I can omit the removal of option() in the patch.

georgmartius commented 10 years ago

Yes, I think the shared objects should be build by default. But you write that something disrupts toolchain files. What do you mean by that?

TimothyGu commented 10 years ago

In mxe we manage the libtype through using a cmake toolchain file which sets or clears BUILD_LIBS_SHARED. However the cmake toolchain file is applied before the option default is set, which means the so-called "initial" or "default" value overrides the user-applied setting.

georgmartius commented 10 years ago

Mh, I see. this seams a general problem, how is it solved by other projects. I want options and they should have default values. I think that for normal usages the shared libs should be by default on. Do you see a way of achieving this?

xantares commented 10 years ago

-1 it was fine before

TimothyGu commented 10 years ago

I decided to drop the patch.

trickkiste commented 7 years ago

So what do I have to do, in order to compile vidstab for static linking into ffmpeg?