CMake: Use cmake's way of setting std and don't set fPIC if windows

georgmartius / vid.stab

Video stabilization library

http://public.hronopik.de/vid.stab/

Other

838 stars 110 forks source link

CMake: Use cmake's way of setting std and don't set fPIC if windows #90

Closed 1480c1 closed 3 years ago

1480c1 commented 3 years ago

I can revert CMake: Use CMAKE_C_STANDARD to set the std flag if wanted since I do not see it in cmake 2.8.5's doc and it seems to mainly be available from 3.1

on windows, clang will error out if -fPIC is set, gcc will warn that it doesn't have any effect and will treat it as a noop

georgmartius commented 3 years ago

Dear Christopher,

again, many thanks for the improvement!

Georg