search

georgringer / cart_stripe

Stripe for TYPO3 extension cart
1 stars 1 forks source link

Clean up code #3

Open rintisch opened 1 month ago

rintisch commented 1 month ago

I am wondering about some lines of code:

  1. Why is the persisting of the updated payment on success out commented? https://github.com/georgringer/cart_stripe/blob/1bcc0f29840f1acb9cd2fe27690002b83365c366/Classes/Controller/Order/PaymentController.php#L104
  2. Can we remove line 3? https://github.com/georgringer/cart_stripe/blob/1bcc0f29840f1acb9cd2fe27690002b83365c366/Configuration/TypoScript/setup.typoscript#L1-L3
  3. Can we remove this? https://github.com/georgringer/cart_stripe/blob/1bcc0f29840f1acb9cd2fe27690002b83365c366/Classes/Controller/Order/PaymentController.php#L264-L277 4.And can we also remove this? https://github.com/georgringer/cart_stripe/blob/1bcc0f29840f1acb9cd2fe27690002b83365c366/Classes/EventListener/Order/Payment/ClearCart.php#L18
georgringer commented 1 month ago

yes remove all ;)

rintisch commented 1 month ago

Okay. But I am still wondering about the first point. Why is the payment no longer stored on success?

georgringer commented 1 month ago

guess removed on debug purpose, can be reactivated