settings.archiveRestriction = none doesn't work

georgringer / news

TYPO3 Extension news

GNU General Public License v2.0

263 stars 357 forks source link

settings.archiveRestriction = none doesn't work #1449

Open maslme opened 3 years ago

maslme commented 3 years ago

Bug Report

Current Behavior A Plugin with settings.archiveRestriction "keine Einschränkung" display only archived news.

Expected behavior/output All news should be displayed whether they are archived or active.

Environment

TYPO3 version(s): 10.4.12
news version: 8.5.2
Is your TYPO3 installation set up with Composer (Composer Mode): no

Comments Beside that, settings.archiveRestriction = archived and settings.archiveRestriction = active works as expected.

georgringer commented 3 years ago

reading the code this is strange, see https://github.com/georgringer/news/blob/master/Classes/Domain/Repository/NewsRepository.php#L129-L140

which only checks for archived and active.

can you debug that?

maslme commented 3 years ago

Okay, I've needed a while to reproduce this. I've forgotten one thing to mention in my description above: The behaviour only occurs, when in the Typoscript Template settings.archiveRestriciton = archived oder active is set. Then this wouldn't be overwritten by the plugin with archiveRestriction = none.