search

georgringer / news

TYPO3 Extension news
GNU General Public License v2.0
265 stars 355 forks source link

TYPO3 12 eventnews plugin xml configuration is lost after upgrade wizard "txNewsPluginUpdater" #2298

Closed luisbecker-gh closed 11 months ago

luisbecker-gh commented 11 months ago

Bug Report

Current Behavior The configuration for the plugin settings settings.eventRestriction is lost, when running the upgrade wizard "txNewsPluginUpdater" because it is not part of the returned array from getAllowedSettingsFromFlexForm in PluginUpdater.php.

Expected behavior/output Wizard should not delete parts of the plugin configuration

Environment

Possible Solution Add the additional Flexform settings to the allowed settings, if eventnews is loaded.

Additional context I know its more an EXT:eventnews bug, but I think it could be resolved in the Plugin Updater Class in EXT:news with ExtensionManagementUtility::isLoaded('eventnews'). Alternatively, it could also be solved with an Xclass in EXT:eventnews. I am happy to write a fix and pull request.

georgringer commented 11 months ago

please use main version of both exts

luisbecker-gh commented 11 months ago

ah i only looked at the tagged versions and github issues. Thanks!