georgringer / t3monitoring_client

Monitoring client
GNU General Public License v2.0
28 stars 26 forks source link

False positive in TYPO3 8.7.1 - reason is missing TCA #26

Open andre-spindler opened 7 years ago

andre-spindler commented 7 years ago

I got warning "Remaining updates - Update Incomplete | This installation is not configured for the TYPO3 version it is running. [...]" But in InstallTool all steps of upgrade are completed.

Reason is the following: t3monitoring_client fetches status from EXT:reports. Update "TYPO3\CMS\Install\Updates\CommandLineBackendUserRemovalUpdate" calls "TYPO3\CMS\Core\Database\Query\Restriction\DeletedRestriction" when building the query to look for old CLI* users. But at this moment $GLOBALS['TCA']['be_users'] is empty. So the deleted field could not be fetched, and the restriction to ignore deleted records is not included. If there exists a deleted user "_cli_scheduler", this will be returned from method "getUnneededCommandLineUsers()", although it has been deleted. But only marked as deleted as usual, not removed from db.

Solution: Load TCA for table be_users before fetching data from reports extension

liayn commented 8 months ago

Is this still an issue?