georgymh / decentralized-ml

Interoperable and decentralized machine learning.
Apache License 2.0
9 stars 5 forks source link

Add pep8 step to the tests and fix all warnings #15

Open georgymh opened 6 years ago

georgymh commented 6 years ago

I ran find . -name \*.py -not -path "*.ipynb_checkpoints*" -exec pep8 {} + at the current state of the master branch and there were 600+ PEP8 warnings.

As an effort to maintain good code quality, we should make a PR that fixes these warnings. We should also add a check on the local and TravisCI tests that verifies we're not bringing the code quality down with any new PR.

To check the warnings, use the pep8 module. To attempt to auto-fix them, use the autopep8 module. Both modules can be installed using pip.

The command to auto-fix would be find . -name \*.py -not -path "*.ipynb_checkpoints*" -exec autopep8 --recursive --aggressive --aggressive --in-place {} +. We will obviously need to manually check that things don't break after running this command.