georgymh / decentralized-ml

Interoperable and decentralized machine learning.
Apache License 2.0
9 stars 5 forks source link

Secret Config #21

Closed neeleshdodda44 closed 6 years ago

neeleshdodda44 commented 6 years ago

For sake of ease, define secret sections as config sections that the user should not touch. Meaning, the user should not touch any entry in the section. Based on the modules we have, I assumed that sections were either entirely secret or entirely customizable (i.e. Scheduler is customizable, DBClient is secret). If this doesn't hold true, I can easily switch to commenting on each entry that the user shouldn't touch (although it would look a lot more messy).

Major changes:

This is what secret sections would look like now:

; DO NOT MODIFY THIS SECTION
[DB_CLIENT]
user = datashark
db = datasharkdb
host = datasharkdatabase.cwnzqu4zi2kl.us-west-1.rds.amazonaws.com
port = 5432
table_name = category_labels
max_tries = 3
wait_time = 10
neeleshdodda44 commented 6 years ago

@nzoghb This PR explains how secret configurations work. Just FYI since all configurations should now be in configuration.ini.