Integrated DB Client + Cleaned up ED Directory Push - Githubissues

georgymh / decentralized-ml

Interoperable and decentralized machine learning.

Apache License 2.0

9 stars 5 forks source link

Integrated DB Client + Cleaned up ED Directory Push #39

Closed neeleshdodda44 closed 5 years ago

neeleshdodda44 commented 5 years ago

Several changes with pushing ED Directories:

Config Manager asks the user to label the data, which is put in the config
Dataset Manager pulls label from the config
To keep design simple, tuples of (dataset_sample, dataset_metadata) are pushed for each folder in the ED Directory
DB Client adds label for data provider on ED Directory push
Added test for DB Client back in (test seems to always pass for now?)
Added test for checking format of ED Directory

TODOs:

We need to eventually have a classifier that labels data automatically
explora currently assumes that each folder has just the sample (and not the tuple of sample,metadata) so this needs to be updated
explora currently extracts metadata from the samples of data, when it should now use this metadata.

neeleshdodda44 commented 5 years ago

Fair point, I replaced labels -> classifications in documentation and code to make this clear. I'll do the same for DB Client in explora too.

Merging now.