Closed vadimi closed 2 years ago
@georgysavva I also feel like some of the docs in in doc.go don't make much sense in v2 of the package, especially around custom types
Merging #97 (a5421a1) into master (3003c11) will decrease coverage by
0.06%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 82.81% 82.74% -0.07%
==========================================
Files 5 5
Lines 512 510 -2
==========================================
- Hits 424 422 -2
Misses 73 73
Partials 15 15
Flag | Coverage Δ | |
---|---|---|
unittests | 82.74% <ø> (-0.07%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pgxscan/pgxscan.go | 70.00% <ø> (-0.74%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@vadimi Thanks for this PR!
@georgysavva I also feel like some of the docs in in doc.go don't make much sense in v2 of the package, especially around custom types
I fixed the pgxscan docs part regarding pgtype. Did I get it right? What else do you find irrelevant for the v2 package?
@georgysavva this is great, thank you
It looks like in pgx v5
github.com/jackc/pgtype
package needs to be replaced withgithub.com/jackc/pgx/v5/pgtype
https://github.com/jackc/pgx/blob/f803c790d0999e9028cbffefad9df02e4aff913a/CHANGELOG.md#merged-packages
as mentioned by @kohenkatz in PR #94