search

georules / adblock-detect

detect if adblock is running!
http://georules.github.io/adblock-detect/test.html
MIT License
4 stars 2 forks source link

Does not differentiate Firefox blocking #2

Open anseljh opened 8 years ago

anseljh commented 8 years ago

I tried the test page, and even with my blocker (Ghostery) disabled, I get adblock is running.

It turns out that Firefox is blocking the third-party script from running anyway.

firefox-blocking

The end result is the same, so I am not sure whether you would consider this a bug or not.

georules commented 8 years ago

This isn't just a firefox issue; I believe the mechanism used is now completely broken. In chrome where I have adblock running, adblock-detect says that it is not. I haven't looked at this project in 2 years -- I'm not sure what other approaches might be used at this point. I am open to suggestions!

The now unworking method was to detect if a script from google that is commonly used for showing ads modifies the DOM. https://github.com/georules/adblock-detect/blob/master/adblock-detect.js#L8

georules commented 8 years ago

I updated the readme so that I do not mislead anyone visiting this project.