georust / gdal

Rust bindings for GDAL
https://crates.io/crates/gdal
MIT License
339 stars 92 forks source link

Add support for VCPKG on Windows #493

Open aljen opened 7 months ago

aljen commented 7 months ago
metasim commented 7 months ago

@aljen Thanks for the PR! I'm not a windows (nor vcpkg) guy, so not sure how to review this. I'll reach out to the community in discord and see if anyone volunteers.

aljen commented 7 months ago

@aljen Thanks for the PR! I'm not a windows (nor vcpkg) guy, so not sure how to review this. I'll reach out to the community in discord and see if anyone volunteers.

No problem! :) I could walk you through it, btw it's easier to follow if in 'files changed' you click gear icon and hide whitespace changes. It's just an additional if, which if detected that we want to use gdal from VCPKG, it helps rust see libs from it, and in case of static variant, adds missing system's dlls dependencies :)

lnicola commented 6 months ago

Ping @aljen can you take another look at this?

aljen commented 6 months ago

Yeah, I planned to do this over the weekend, I had my plate full lately :)