georust / gdal

Rust bindings for GDAL
https://crates.io/crates/gdal
MIT License
339 stars 92 forks source link

Implemented `Feature::set_field_null` #501

Closed metasim closed 6 months ago

metasim commented 6 months ago

Closes #427 Credit to @nms-scribe

lnicola commented 6 months ago

I was too afraid to check in #427, looked at the docs now, but still have no idea. Does anyone know the difference between OGR_F_SetFieldNull and OGR_F_UnsetField?

Does the latter actually remove the field value in formats like GeoJSON?

metasim commented 6 months ago

Docs:

@lnicola Yeah, I don't understand the semantics either.

Maybe we just mark this as "draft" and come back to it later?

lnicola commented 6 months ago

No, I would have merged it, but unsetting all fields of all features in all layers seems a bit excessive. But it's only 21 features, so feel free to merge :slightly_smiling_face:.

metasim commented 6 months ago

I simplified the test.