search

georust / gdal

Rust bindings for GDAL
https://crates.io/crates/gdal
MIT License
339 stars 92 forks source link

Drop pre-3.0 GDAL support #504

Closed lnicola closed 6 months ago

lnicola commented 6 months ago

Closes #477 Closes #467

lnicola commented 6 months ago

Added version info support to the README and a commit to drop the pre-built 2.4 bindings. Will wait a little before merging, since it's the kind of change that might make people upset.

lnicola commented 6 months ago

r? @metasim

metasim commented 6 months ago

@lnicola What do you think about holding back this PR until after the 0.17 release? Since the pre-3.0 support works up to now, it would give legacy users one more release (with lots of improvements) to work with.

lnicola commented 6 months ago

@metasim 2.4 is broken anyway, #467. We could fix it, but I don't think it's worth it since not many people complain.

valarauca commented 6 months ago

FYI the docs.rs page for the project does state 2.4 to 3.X is supported, so that should also be updated in this patch series.

lnicola commented 6 months ago

Thanks for spotting that, updated in https://github.com/georust/gdal/pull/504/commits/0f2996a3bed2b30393ff7de935ec2badbfcbd183.

lnicola commented 6 months ago

@metasim there wasn't much negative feedback, do you think we could merge this?

metasim commented 6 months ago

@lnicola Yes! Go for it!