georust / gdal

Rust bindings for GDAL
https://crates.io/crates/gdal
MIT License
359 stars 94 forks source link

Added `no_data_value_u64`, `set_no_data_value_u64`, `no_data_value_i64` and `set_no_data_value_i64` to `RasterBand` #520

Closed metasim closed 8 months ago

metasim commented 8 months ago

Adds RasterBand::no_data_value_u64 and RasterBand::no_data_value_i64, etc.

lnicola commented 8 months ago

Can you resample those to 1x1 and maybe merge them into a single file?

metasim commented 8 months ago

Just realized I should add the setters too. Not enough coffee this morning...

lnicola commented 8 months ago

Good idea, I was actually wondering if there's any way to set it. Might make sense to use a larger value then, like 2^62.

metasim commented 8 months ago

Can you resample those to 1x1 and maybe merge them into a single file?

How about a 1x2 so we can have a data value and a no-data value?

metasim commented 8 months ago

Good idea, I was actually wondering if there's any way to set it. Might make sense to use a larger value then, like 2^62.

I basically neglected to see these

lnicola commented 8 months ago

Doesn't seem necessary to me, but sure it doesn't matter. Could come in handy in the future, who knows?

metasim commented 8 months ago

Doesn't seem necessary to me...

What are you referring to here? The comment sequence is confusing.

lnicola commented 8 months ago

I meant that about the second pixel with a valid value. I don't think it's needed to test these functions, but they could be useful in a simple warping/resampling test.

lnicola commented 8 months ago

Please squash at the end!

lnicola commented 8 months ago

:facepalm:

EDIT: nvm, my bad.