Closed frewsxcv closed 1 year ago
I just added the merge_group
setting as per the docs (and as seen in the geojson
repo). Shall we do this?
Let's hold off until we figure out what we're doing wrong with our settings. e.g. see
https://github.com/georust/proj/pull/169 https://github.com/georust/proj/pull/170 https://github.com/georust/proj/pull/171 https://github.com/georust/proj/pull/172 https://github.com/georust/proj/pull/173 https://github.com/georust/proj/pull/174 https://github.com/georust/proj/pull/175
I've rebased and pushed up some commits to this branch (I hope that's OK!)
Based on what we discovered in https://github.com/georust/proj/pull/179, I updated our workflow to get merge queues functioning how we want.
I also pushed up another commit with a failing test so we can double check that things are functioning as expected.
If I get a :+1: we can click "merge when ready" and hopefully it will fail to merge from the failing test. Then we can revert the failing test commit and everything should be gravy.
Update: failing as expected ->
Clicked "merged when ready"...
Hopefully this will fail to merge, and then I can revert the failing test commit.
Cool, seems to be doing the right thing so far. It won't merge because of the failing check. Let me revert that problematic commit now.
bors is dead, long live the merge queue.
goodbye bors. 😢
[ ] I added an entry to
CHANGES.md
if knowledge of this change could be valuable to users.