Closed JosiahParry closed 1 year ago
@frewsxcv thanks! I've added a note in the documentation that it uses euclidean distance. Is this explicit enough?
I've also added a handful of tests as well. Please let me know if this is sufficient or if there ought to be exhaustive tests (every combo of geometry types).
I've pushed a commit that addresses formatting using cargo fmt
.
I've added a note to the changelog. Please let me know what else is needed to close this PR. Thanks! :)
bors r+
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.
Additional information:
Response status code: 422
{"message":"Changes must be made through the merge queue","documentation_url":"https://docs.github.com/articles/about-protected-branches"}
bors retry
Whoops. My bad I think. Let's try again now that I have (for real this time) disabled the merge queue.
Build succeeded!
The publicly hosted instance of bors-ng is deprecated and will go away soon.
If you want to self-host your own instance, instructions are here. For more help, visit the forum.
If you want to switch to GitHub's built-in merge queue, visit their help page.
Thanks!
Thank you!
CHANGES.md
if knowledge of this change could be valuable to users.This PR adds a new trait
HausdorffDistance
which is implemented for all geometries.This is my first Rust library PR so I'll need some guidance getting this through the finish line!
Outstanding questions for maintainers:
CHANGES.md
does not have a development version listed, how should it be modified?