georust / geo

Geospatial primitives and algorithms for Rust
https://crates.io/crates/geo
Other
1.49k stars 194 forks source link

chore: remove unused impl of private trait ActiveSet #1048

Closed RobWalt closed 11 months ago

RobWalt commented 12 months ago

The motivation for removing this is that it is a bit misleading and confusing when starting to look deeper into the code. I spent quiet some time trying to wrap my head around why we need this but it was simply unused.

This seem to be leftover parts of an earlier implementation. The trait is private, so there is no chance that this will break user code. I also made sure to check that the trait impl for BTreeSet isn't used anymore. It has been completely replaced by VecSet everywhere.

rmanoka commented 11 months ago

Yes, it's a left-over from a previous implementation but I wasn't sure if we'll switch back to BTreeSet so left it in there. We can remove this if it helps with some linting.