georust / geo

Geospatial primitives and algorithms for Rust
https://crates.io/crates/geo
Other
1.49k stars 194 forks source link

Vw refactor #1052

Closed urschrei closed 9 months ago

urschrei commented 11 months ago

This is a refactor of both VW and VwPreserve, partially in response to #1049:

frewsxcv commented 10 months ago

@urschrei Is this ready for review?

urschrei commented 10 months ago

Nope: it turns out that JTS and GEOS have different interpretations of the input epsilon: JTS uses epsilon ^ 2 for the VW algorithm, and GEOS uses epsilon. We currently use epsilon, but as @michaelkirk pointed out, GEOS is downstream of JTS and there was discussion of whether to bring our implementation in line with JTS (and also why GEOS made that decision, which also affects Shapely and PostGIS) or stick with what we have. Discussion has stalled, so I guess we can revisit next week and make a decision, at which point this'll be reviewable.

urschrei commented 9 months ago

This is ready for review if anyone's feeling inclined!