search

georust / geo

Geospatial primitives and algorithms for Rust
https://crates.io/crates/geo
Other
1.49k stars 194 forks source link

Add 1.70, 1.71 to CI, bump MSRV to 1.65 #1067

Closed michaelkirk closed 10 months ago

michaelkirk commented 10 months ago

1.65 was released more than 10 months ago: https://blog.rust-lang.org/2022/11/03/Rust-1.65.0.html

Notably (for me anyway because I keep trying to use it) this means we can use let/else syntax.

As a reminder, our policy has been to support at least the last 6 months (STABLE + 3 prior), but I usually bump it conservatively to whatever feature is causing annoyance.

michaelkirk commented 10 months ago

Oh, 1.65 also includes generic associated types (GATs). #908 👀

lnicola commented 10 months ago

We should also bump rust-version in the manifest files.

michaelkirk commented 10 months ago

We should also bump rust-version in the manifest files.

Good catch! Done.

lnicola commented 10 months ago

There's also geo-postgis and maybe even others. And the error here:

error: private item shadows public glob re-export
   --> geo/src/lib.rs:206:1
    |
206 | extern crate proj;
    | ^^^^^^^^^^^^^^^^^^
    |
note: the name `proj` in the type namespace is supposed to be publicly re-exported here
   --> geo/src/lib.rs:209:9
    |
209 | pub use crate::algorithm::*;
    |         ^^^^^^^^^^^^^^^^^^^
note: but the private item here shadows it
   --> geo/src/lib.rs:206:1
    |
206 | extern crate proj;
    | ^^^^^^^^^^^^^^^^^^
    = note: `-D hidden-glob-reexports` implied by `-D warnings`
lnicola commented 10 months ago

Heads-up: I'm gonna try the rebase button :smile:.

lnicola commented 10 months ago

Not sure what's up with the failing tests. cs2cs EPSG:2230 EPSG:26946 and cs2cs EPSG:4326 EPSG:2230 work fine in georust/geo-ci:proj-9.2.1-rust-1.72.

michaelkirk commented 10 months ago

I'm not sure what's going on with the proj build.

These lines are suspicious:

proj_create: Cannot find proj.db
test algorithm::map_coords::test::test_fallible_proj ... FAILED
proj_create: no database context specified

I think that rust-1.72 is the first release on the new debian "bookworm" distro. Not sure if that's relevant. It did force me to change the libtiff dependency to something that would (I hoped) work across releases.

michaelkirk commented 10 months ago

Fixed with https://github.com/georust/docker-images/pull/26/commits/112764c97c46e8d7ffc9e94e4921ffa3877820a1

I'm not sure what's wrong with our setup vs. debian-bookworm, but I'm happy to kick that can down the road.