search

georust / geo

Geospatial primitives and algorithms for Rust
https://crates.io/crates/geo
Other
1.48k stars 191 forks source link

Introduce `total_cmp` on GeoNum to avoid unwraps #1134

Closed michaelkirk closed 6 months ago

michaelkirk commented 6 months ago

In particular the latest home crate used by bindgen, required by proj, needs rust-1.70+

Also updates CI containers to latest

urschrei commented 6 months ago

Is the TotalOrd trait requirement a result of the MSRV bump?

urschrei commented 6 months ago

Ah, just read the commit message. It's due to a lint introduced in Rust 1.75

michaelkirk commented 6 months ago

@rmanoka - did you want to weigh in on this? I've gotten a few positive responses so far so I'm going to go ahead and merge it in a couple days if I don't hear from you.

rmanoka commented 6 months ago

Looks good to me too! +1 for merge.