search

georust / geo

Rust geospatial primitives & algorithms
https://crates.io/crates/geo
Other
1.58k stars 199 forks source link

Converter functions for geo-traits to geo-types #1255

Closed kylebarron closed 1 week ago

kylebarron commented 3 weeks ago

Closes #1253

kylebarron commented 2 weeks ago

@michaelkirk any thoughts?

michaelkirk commented 2 weeks ago

I'm on holiday for a couple weeks so can't really look closely. The approach looks good though! I'm happy to see it merged if someone else approves.

kylebarron commented 2 weeks ago

I don't think this will merge until Michael removes his request for changes.

frewsxcv commented 2 weeks ago

Ugh is main broken again

urschrei commented 2 weeks ago

It's failing on Clippy due to deprecations and a JTS overlay test, both related to i_overlay, which had a release (1.8) yesterday. We were on 1.7.2

urschrei commented 1 week ago

@frewsxcv i_overlay 1.8 was breaking (I think intentionally), so we can't merge til we either pin to 1.72, or adapt the converter module to the new API.

kylebarron commented 1 week ago

adapt the converter module to the new API.

I don't think anything in this PR touches i_overlay?

urschrei commented 1 week ago

adapt the converter module to the new API.

I don't think anything in this PR touches i_overlay?

Sorry, I meant the boolops module that handles interaction with i_overlay!